EkfdPredict and GmekfPredict classes and tests#7
Open
bschneiderheinze wants to merge 4 commits intoscope-lab:mainfrom
Open
EkfdPredict and GmekfPredict classes and tests#7bschneiderheinze wants to merge 4 commits intoscope-lab:mainfrom
bschneiderheinze wants to merge 4 commits intoscope-lab:mainfrom
Conversation
…h both pass. EkfdPredict test checked against manual ekf update, checked that a diagonal H implies a diagonal W, and checked against KfdPredict for linear measurements. GmekfPredict test checked against EkfdPredict for single mixand, checked that weights get heavily scaled down for non-agreeing measurements, and checked against GmkfPredict for linear measurements.
keithalegrand
requested changes
Oct 29, 2025
pyest/filters/KalmanFilter.py
Outdated
| (ny,ny) measurement noise covariance matrix | ||
| H : ndarray or callable | ||
| (nz,nx) measurement Jacobian matrix | ||
| z_k = H(tk, xk, *args) @ x. If provided an ndarray instead, H will |
Contributor
There was a problem hiding this comment.
Here, we may want to force the user to specify H as a callable to avoid user errors caused by using an incorrect constant Jacobian
Author
There was a problem hiding this comment.
I changed it to be consistent with the handling of F in EkfdPredict, where it is documented as a callable but if provided an ndarray is still recast as a callable. I can add an error/warning if we want that though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added classes for EkfdPredict and GmekfPredict to filters, and respective tests to tests. The tests should be comprehensive and they fully pass.